Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from monotonic to time module #310

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

rudyardrichter
Copy link
Contributor

@rudyardrichter rudyardrichter commented Sep 15, 2023

Since 3.3 there's a time.monotonic() function which implements this behavior, so the monotonic dependency (which is no longer maintained) can be removed.

(Hope the PR is welcome! I figured this tweak was small enough I'd just open this rather than file an issue first.)

Copy link
Collaborator

@nd4p90x nd4p90x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@nd4p90x
Copy link
Collaborator

nd4p90x commented Oct 11, 2023

@rudyardrichter Looks like there are unresolved conflicts, can you resolve them?

Thanks,

@rudyardrichter
Copy link
Contributor Author

Thanks @nd4p90x ! Should be updated now.

@MichaelGHSeg MichaelGHSeg merged commit e83dc0d into segmentio:master Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants