Adding apiHost from segment.io settings, or default #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has to include protocol (https://), but apiHost must not)
🦋 Changeset detectedLatest commit: c143e4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
reviewed
Sep 26, 2024
| const segmentLoadOptions = options?.integrations?.['Segment.io'] as | ||
| | SegmentioSettings | ||
| | undefined | ||
| const apiHost = segmentLoadOptions?.apiHost |
There was a problem hiding this comment.
This isn't the final value afaik? these loadOptions are just overrides -- we would need to take into account the cdnSettings apiHost value.
One option is to just make this a getter to analytics.queue and create a metadata object on the plugin -- that way, don't have to recreate the logic in two places.
silesky
force-pushed
the
MichaelGHSeg/api-host-api
branch
from
6b679a5
to
b50f7b1
Compare
silesky
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that cdnURL has to include protocol (https://), but apiHost must not)
yarn changeset. Read about changesets here).