From 4e07428e23bb9066b37aaa639c530fab7b5add57 Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 27 Sep 2024 19:58:28 -0500 Subject: [PATCH] wip --- .../signals-vanilla/change-input.test.ts | 13 +++------ .../signals-vanilla/signals-redaction.test.ts | 27 +++++-------------- 2 files changed, 9 insertions(+), 31 deletions(-) diff --git a/packages/signals/signals-integration-tests/src/tests/signals-vanilla/change-input.test.ts b/packages/signals/signals-integration-tests/src/tests/signals-vanilla/change-input.test.ts index a62e3967c..0d301ce79 100644 --- a/packages/signals/signals-integration-tests/src/tests/signals-vanilla/change-input.test.ts +++ b/packages/signals/signals-integration-tests/src/tests/signals-vanilla/change-input.test.ts @@ -27,7 +27,7 @@ test('Collecting signals whenever a user enters text input', async ({ ) const interactionSignals = indexPage.signalsAPI.getEvents('interaction') - const data = expect.objectContaining({ + const data = { eventType: 'change', target: expect.objectContaining({ attributes: expect.objectContaining({ @@ -47,13 +47,6 @@ test('Collecting signals whenever a user enters text input', async ({ tagName: 'INPUT', value: 'John Doe', }), - }) - expect(interactionSignals[0]).toMatchObject({ - event: 'Segment Signal Generated', - type: 'track', - properties: { - type: 'interaction', - data, - }, - }) + } + expect(interactionSignals[0].properties!.data).toMatchObject(data) }) diff --git a/packages/signals/signals-integration-tests/src/tests/signals-vanilla/signals-redaction.test.ts b/packages/signals/signals-integration-tests/src/tests/signals-vanilla/signals-redaction.test.ts index 3aac98be7..6540078bc 100644 --- a/packages/signals/signals-integration-tests/src/tests/signals-vanilla/signals-redaction.test.ts +++ b/packages/signals/signals-integration-tests/src/tests/signals-vanilla/signals-redaction.test.ts @@ -24,22 +24,15 @@ test('redaction enabled -> will XXX the value of text input', async ({ ) const interactionSignals = indexPage.signalsAPI.getEvents('interaction') - const data = expect.objectContaining({ + const data = { eventType: 'change', target: expect.objectContaining({ name: 'name', type: 'text', value: 'XXX', // redacted }), - }) - expect(interactionSignals[0]).toMatchObject({ - event: 'Segment Signal Generated', - type: 'track', - properties: { - type: 'interaction', - data, - }, - }) + } + expect(interactionSignals[0].properties!.data).toMatchObject(data) }) test('redation disabled -> will not touch the value of text input', async ({ @@ -60,19 +53,11 @@ test('redation disabled -> will not touch the value of text input', async ({ ) const interactionSignals = indexPage.signalsAPI.getEvents('interaction') - const data = expect.objectContaining({ + const data = { eventType: 'change', target: expect.objectContaining({ value: 'John Doe', // noe redacted }), - }) - - expect(interactionSignals[0]).toMatchObject({ - event: 'Segment Signal Generated', - type: 'track', - properties: { - type: 'interaction', - data, - }, - }) + } + expect(interactionSignals[0].properties!.data).toMatchObject(data) })