Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth2 for webhook2.0 #2334

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

cyberlord29
Copy link
Contributor

@cyberlord29 cyberlord29 commented Aug 26, 2024

For Webhooks 2.0 which is an extensible destination, more like a generic webhook that has OAuth2 and custom settings that are dynamic.

This PR adds Oauth 2 for the new destination webhook-extensible and an HTTP send action.

SDD

Testing

Added unit tests and ran a regression test

@joe-ayoub-segment
Copy link
Contributor

hi @cyberlord29 please ping me directly when this PR is ready for review.

@cyberlord29 cyberlord29 marked this pull request as ready for review September 23, 2024 14:21
@cyberlord29 cyberlord29 requested a review from a team as a code owner September 23, 2024 14:21
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (5a5f52b) to head (78251a8).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
.../src/destinations/webhook-extensible/send/index.ts 44.44% 8 Missing and 2 partials ⚠️
...tions/src/destinations/webhook-extensible/index.ts 66.66% 2 Missing ⚠️
packages/core/src/destination-kit/action.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2334       +/-   ##
===========================================
+ Coverage   33.18%   78.98%   +45.79%     
===========================================
  Files          14     1210     +1196     
  Lines         693    21954    +21261     
  Branches      109     4448     +4339     
===========================================
+ Hits          230    17340    +17110     
- Misses        463     3542     +3079     
- Partials        0     1072     +1072     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look good to me. Left couple of questions.

We need to ensure that actions-core changes don't break any existing behaviour. A hadron regression run can be helpful. I can help you do that tomorrow.

yarn.lock Outdated Show resolved Hide resolved
packages/core/src/destination-kit/index.ts Show resolved Hide resolved
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Oct 2, 2024

hi @sayan-das-in - would you be able to review the core change in this PR please? I'm not concerned about the Destination specific code so you can ignore that - but there is a core change in Destination Kit which I'd like someone experienced to review.

@cyberlord29 is keen to get this out today if possible.

edit: I can see that the folks in India are OOO today. So unfortunately this PR will have to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants