Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Dark Mode, grayed-out menu items look like normal menu items #763

Closed
t-m-w opened this issue Oct 3, 2024 · 2 comments
Closed

In Dark Mode, grayed-out menu items look like normal menu items #763

t-m-w opened this issue Oct 3, 2024 · 2 comments
Assignees

Comments

@t-m-w
Copy link
Collaborator

t-m-w commented Oct 3, 2024

Screenshots:

Light Dark

The Light screenshot shows grayed-out "Backup now" and "Restore backup" menu items. The Dark screenshot shows "Backup now" and "Restore backup" menu items that are the same color as the others.

The effect is that the user may be confused by nothing happening when they tap one of these items.

May be related to #750

@grote
Copy link
Collaborator

grote commented Oct 3, 2024

@theimpulson I think this is related to your MD3 changes. Do you know how to bring back disabled menu items in dark theme?

@theimpulson
Copy link
Collaborator

theimpulson commented Oct 13, 2024

This should be fixed by dropping the theme attribute from the Toolbar. I have included this in #776 PR but we can move it to a standalone one too if required.

dc0a511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants