Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard covers up recovery code entry #754

Closed
t-m-w opened this issue Sep 26, 2024 · 4 comments
Closed

Keyboard covers up recovery code entry #754

t-m-w opened this issue Sep 26, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@t-m-w
Copy link
Collaborator

t-m-w commented Sep 26, 2024

The recovery code entry screen no longer adapts to show input fields that would otherwise be under the keyboard. This happens when restoring a backup or when verifying the recovery code - inside and outside of the Setup Wizard.

screen-20240926-170403.trimmed.webm

Pretty sure (but not entirely sure) that this is caused by #750 because I do not see it in CalyxOS 5.11.2.

@t-m-w t-m-w added the bug label Sep 26, 2024
@grote
Copy link
Collaborator

grote commented Sep 27, 2024

Pretty sure (but not entirely sure) that this is caused by #750 because I do not see it in CalyxOS 5.11.2.

We didn't really change anything there. More likely is an Android 15 and/or library upgrade behavior change.

@grote
Copy link
Collaborator

grote commented Sep 27, 2024

@theimpulson could your edge to edge changes have caused this?

@grote grote added this to the 3.x milestone Sep 27, 2024
@grote
Copy link
Collaborator

grote commented Sep 27, 2024

Yeah that was it. @theimpulson's code didn't account for the IME insets. Something to keep in mind when testing this kind of change: always try the keyboard!

@t-m-w
Copy link
Collaborator Author

t-m-w commented Sep 30, 2024

Can confirm this is fixed in latest app-backup-v2!

@t-m-w t-m-w closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants