Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back stack handling may cause display of outdated state #751

Closed
t-m-w opened this issue Sep 24, 2024 · 4 comments
Closed

Back stack handling may cause display of outdated state #751

t-m-w opened this issue Sep 24, 2024 · 4 comments
Labels

Comments

@t-m-w
Copy link
Collaborator

t-m-w commented Sep 24, 2024

In some circumstances, the "Included files and folders" page of Storage Backup might incorrectly show an outdated state of the categories toggles, even if one or more had been turned on previously. Tapping to turn on one category updates the state of the rest of them; e.g., if they were all turned on before, the others will correctly appear to be turned on again immediately after tapping one of them.

I think this is related to launching Seedvault from the notification, which appears to create another instance of the Seedvault activity.

Steps to reproduce (untested, guessing):

  1. Open Seedvault.
  2. Start a backup.
  3. In Seedvault settings, visit the "Included files and folders" page under the Storage Backup section. Turn on Storage Backup first if needed.
  4. Note the category toggles, e.g. all off.
  5. Remain on this page. Wait for the backup to finish.
  6. When the backup finishes, tap the finish notification, which will open Seedvault settings.
  7. Navigate to the "Included files and folders" page again. This time, alter at least one of the toggles.
  8. Navigate back a few times, and you should end up at the "Included files and folders" page again.

Expected result (untested, guessing):
The page properly represents your recently-changed settings.

Actual result (untested, guessing):
The page shows the state of the toggles from before you changed them. Changing one toggle will refresh it.

Possibly related somehow (because I am including this): #750

@t-m-w t-m-w added the bug label Sep 24, 2024
@t-m-w t-m-w changed the title Storage Backup inclusion list may incorrectly display all categories as turned off Storage Backup inclusion page may incorrectly display all categories as turned off Sep 24, 2024
@t-m-w t-m-w changed the title Storage Backup inclusion page may incorrectly display all categories as turned off Storage Backup inclusion page may incorrectly display the state of category toggles Sep 24, 2024
@t-m-w t-m-w changed the title Storage Backup inclusion page may incorrectly display the state of category toggles Storage Backup inclusion page may display an outdated state of category toggles Sep 24, 2024
@t-m-w t-m-w changed the title Storage Backup inclusion page may display an outdated state of category toggles Storage Backup inclusion page may display an outdated state Sep 24, 2024
@t-m-w
Copy link
Collaborator Author

t-m-w commented Sep 24, 2024

This might affect more than just category toggles and the storage backup page. If possible, having the backup notification not launch a new instance may help -- assuming that's what's happening.

@grote grote changed the title Storage Backup inclusion page may display an outdated state Back stack handling may cause display of outdated state Sep 24, 2024
@grote
Copy link
Collaborator

grote commented Sep 24, 2024

@theimpulson using the navigation library may help with this.

@grote
Copy link
Collaborator

grote commented Sep 27, 2024

@t-m-w when you get the chance may be nice to try this again with latest #750 to see if it still happens there. It may not.

@t-m-w
Copy link
Collaborator Author

t-m-w commented Oct 16, 2024

The steps provided no longer reproduce this issue. Tapping the backup notification brings up the existing Seedvault window if any - no more duplication. It no longer takes you to the backup status screen if Seedvault was already open, unless you were already there. This means "Tap to learn more" won't necessarily directly help you "learn more" now, but that's a separate problem. This problem itself is solved.

@t-m-w t-m-w closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants