Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jakarta.persistence.Table#comment versus @Comment #65

Closed
sebersole opened this issue Nov 2, 2023 · 2 comments
Closed

jakarta.persistence.Table#comment versus @Comment #65

sebersole opened this issue Nov 2, 2023 · 2 comments

Comments

@sebersole
Copy link
Owner

JPA has added #comment to a number of targets where we used to accept our own @Comment.

At the moment, the XSD has both an attribute (Table#comment) and an element (@Comment). We need to decide whether to deprecate @Comment or support both.

Also, what to do with XSD.
@sebersole
Copy link
Owner Author

I went ahead and deprecated our @Comment in favor of #comment on the various table and column annotations (I even marked it @Remove in 6.4, so we could potentially remove it in 7.0).

As for the XSD, JPA decided to make comment an element so I've normalized on that in ours.

@sebersole
Copy link
Owner Author

Nothing to do really

@sebersole sebersole closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebersole