Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method delete_prefix #8

Open
mrbenas opened this issue Jul 19, 2024 · 4 comments
Open

undefined method delete_prefix #8

mrbenas opened this issue Jul 19, 2024 · 4 comments

Comments

@mrbenas
Copy link

mrbenas commented Jul 19, 2024

Hi! After the recent changes in b22384a and release of 1.1.2 our Flay checks have started failing:

~/path_expander-1.1.2/lib/path_expander.rb:58:in `block in expand_dirs_to_files': undefined method `delete_prefix' for #<Pathname:/test/test.rb> (NoMethodError)

    }.flatten.sort.map { |s| s.delete_prefix "./" }
                              ^^^^^^^^^^^^^^
        from ~/path_expander-1.1.2/lib/path_expander.rb:58:in `map'
        from ~/path_expander-1.1.2/lib/path_expander.rb:58:in `expand_dirs_to_files'
        from ~/path_expander-1.1.2/lib/path_expander.rb:113:in `block in process_args'
        from ~/path_expander-1.1.2/lib/path_expander.rb:95:in `each'
        from ~/path_expander-1.1.2/lib/path_expander.rb:95:in `process_args'
        from ~/path_expander-1.1.2/lib/path_expander.rb:147:in `process'
        from ~/flay-2.13.3/lib/flay.rb:26:in `run'
        from ~/pronto-flay-0.11.1/lib/pronto/flay.rb:25:in `flay'
        from ~/pronto-flay-0.11.1/lib/pronto/flay.rb:13:in `run'

It looks like the operation expects a String, but it's being passed a Pathname. Can it be fixed somehow?

@thayol
Copy link

thayol commented Aug 12, 2024

Looks like the fix is already in master. (071a591)
We just need a release and we're good to go!

@KieranP
Copy link

KieranP commented Aug 19, 2024

@zenspider Could we please have a release with the bug fix? Is there anything we can do to help with that process?

@emm26
Copy link

emm26 commented Sep 6, 2024

Hi! Could we have a release, please?

@KieranP
Copy link

KieranP commented Sep 15, 2024

@mrbenas @thayol @emm26 Looks like 1.1.3 was released which fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants