Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviation edge case(s) #37

Open
djdembeck opened this issue Sep 24, 2021 · 7 comments
Open

Abbreviation edge case(s) #37

djdembeck opened this issue Sep 24, 2021 · 7 comments

Comments

@djdembeck
Copy link
Collaborator

Collecting/reporting edge cases as I come across them:

Cornel West - editor, Dr. Martin Luther King Jr.

  • -editor as author results in "The Radical King" by C.W.-editor w/ L.Burton
@rabelux
Copy link

rabelux commented Sep 24, 2021

Another one, similiar to the previous one:

Stephen Fry - introductions, Arthur Conan Doyle

ends up in S.F.-introductions

@rabelux
Copy link

rabelux commented Sep 24, 2021

Wrote a quick fix for these cases but I don't know whether it breaks other scenarios.
So I'd say we collect some more data first.

@seanap
Copy link
Owner

seanap commented Sep 24, 2021

Is there any way to match with the full authors name, but only display the abbreviated name?

@rabelux
Copy link

rabelux commented Sep 24, 2021

That's already the case from my understanding. Search is performed in line 177, further information is gathered in line 192 and the abbreviation takes place in line 220 and 222.

@seanap
Copy link
Owner

seanap commented Sep 24, 2021

That was my understanding as well, sorry I just misinterpreted the edge cases. Looks like it is just not handling author names when there are qualifiers like editor or intro. My bad! Have you tested a book written by a doctor "some name M.D."?

@djdembeck
Copy link
Collaborator Author

djdembeck commented Sep 24, 2021

There is also this list we can add to/use:

author_contributers_list = [
'contributor',
'translator',
'foreword',
'translated',
]

@rabelux
Copy link

rabelux commented Sep 24, 2021

Have you tested a book written by a doctor "some name M.D."?

No I haven't. In german doctor titles are written in front the name so I guess I won't stumble upon this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants