New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds common_code_key attribute to access codes #73

Draft

AxelTheGerman wants to merge 1 commit into seamapi:main from AxelTheGerman:common-code-key

Contributor

AxelTheGerman commented Jan 7, 2024

Unique identifier for a group of access codes that share the same code.

Note: this field is not available when updating access codes, only when creating.


          Adds common_code_key attribute to access codes

c515b94

AxelTheGerman force-pushed the common-code-key branch 3 times, most recently from 3e8694c to c515b94 Compare

January 7, 2024 17:59

Contributor Author

AxelTheGerman commented Jan 7, 2024

Interesting, 2 issues.

it fails in ruby 2.6 because of domain_name
I might be misunderstanding the common_code_key - I thought it would enforce that all codes would be the same that share this key.

But when attempting to create an access code with a code and common_code_key I'm getting:

request_id: 93fd5387-de31-4fcc-8e33-71574ba31024
Cannot provide both common_code_key and code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

abimaelmartell Awaiting requested review from abimaelmartell abimaelmartell will be requested when the pull request is marked ready for review abimaelmartell is a code owner

andrii-balitskyi Awaiting requested review from andrii-balitskyi andrii-balitskyi will be requested when the pull request is marked ready for review andrii-balitskyi is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet