Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support personal access token in environment variable #137

Open
razor-x opened this issue Jul 17, 2024 · 1 comment
Open

Support personal access token in environment variable #137

razor-x opened this issue Jul 17, 2024 · 1 comment

Comments

@razor-x
Copy link
Contributor

razor-x commented Jul 17, 2024

  1. For SeamHttpMultiWorkspace, read SEAM_PERSONAL_ACCESS_TOKEN from env. Add test to env.test.ts. Basically identical logic to how SeamHttp handles SEAM_API_KEY
  2. For SeamHttp, read both SEAM_PERSONAL_ACCESS_TOKEN and SEAM_WORKSPACE_ID. If both SEAM_PERSONAL_ACCESS_TOKEN and SEAM_API_KEY are defined in the env, throw an invalid options error.
@razor-x
Copy link
Contributor Author

razor-x commented Jul 17, 2024

@andrii-balitskyi What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant