-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render errors and warnings #333
Comments
How about something like this?
Question 1: How do we show the format of the errors and warnings? I'm assuming that they're all based on the same error and warning objects, so all errors should have the same set of props, and all warnings should have the same set of props. Is that correct? Is there a way in which we could link to a definition of the error object and the warning object instead of repeating the same prop descriptions over and over again? Question 2: Right now, Events is an H1, at the same level as the resource. If events, errors, and warnings are specifically linked to the resource (not the route), should we shift all the heading levels down one for events, errors, and warnings?
|
Mostly, however now that we can document and type these, I'd like errors and warnings to have more helpful props. Some already do, e.g., we have |
I'd say Events are linked to the route, since we have |
@razor-x, am I correct in understanding that rendering errors/warnings currently cannot be supported since they are not properly documented on seam-connect?
|
@andrii-balitskyi Yes, but they should be properly typed for a acs_system and acs_user. All errors and warnings will be getting proper types. Let's just render the ones that have the types, and have the docsgen just render something generic for the ones that are not. So this issue it not blocked, the next step is an example PR just like this one (or an update to blueprint if needed first): #338 |
We will have separate errors and warnings sections that are children of the resource and look similar to the props section.
The text was updated successfully, but these errors were encountered: