Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONVM Web Update #253

Open
wants to merge 199 commits into
base: develop
Choose a base branch
from
Open

ONVM Web Update #253

wants to merge 199 commits into from

Conversation

WilliamMaa
Copy link
Contributor

<>

Summary:

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements X
Bug fixes
New functionality X
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates X
Web stats updates X

Merging notes:

  • Dependencies: flask, flask_cors, docker.io, python pushgateway client

TODO before merging :

  • PR is ready for review

Test Plan:

This PR contains many updates including Grafana, Prometheus, and new front end for starting nf chains. This should be merged into a different branch as Tim suggested. This can be tested by using the new web interface. If there is any problem, please add comment below and I will fix them as we go.

Review:

(optional) << @-mention people who should review these changes >>
@catherinemeadows @kevindweb since you guys are most familiar with these, maybe you guys should take a look first. Potential problems include the new start_web_console.sh script, it might have some issue in the first time you try to run it. And the current way I'm doing to find out the host IP might not be correct on all Linux systems, please test it and see it would work.
The new flask server does not allow you to directly access localhost:8000, I don't know if that is an issue, but let me know if there's any problem. Grafana is still under testing, the dashboards are not complete, let me know if you have any ideas on how to make better dashboards.
One known issue, when you stop the nf chain, the server might return 500, but it actually have stopped the nfs, I will look into that, but I don't think it would have any effect on using it.

(optional) Subscribers: << @-mention people who probably care about these changes >>

@onvm
Copy link

onvm commented Aug 13, 2020

In response to PR creation

CI Message

Aborting, need an authorized user to run CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants