-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONVM Web Update #253
Open
WilliamMaa
wants to merge
199
commits into
sdnfv:develop
Choose a base branch
from
WilliamMaa:grafana_nf_demo
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ONVM Web Update #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into grafana-setup
… into grafana-setup
CI MessageAborting, need an authorized user to run CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<>
Summary:
Usage:
Merging notes:
TODO before merging :
Test Plan:
This PR contains many updates including Grafana, Prometheus, and new front end for starting nf chains. This should be merged into a different branch as Tim suggested. This can be tested by using the new web interface. If there is any problem, please add comment below and I will fix them as we go.
Review:
(optional) << @-mention people who should review these changes >>
@catherinemeadows @kevindweb since you guys are most familiar with these, maybe you guys should take a look first. Potential problems include the new start_web_console.sh script, it might have some issue in the first time you try to run it. And the current way I'm doing to find out the host IP might not be correct on all Linux systems, please test it and see it would work.
The new flask server does not allow you to directly access localhost:8000, I don't know if that is an issue, but let me know if there's any problem. Grafana is still under testing, the dashboards are not complete, let me know if you have any ideas on how to make better dashboards.
One known issue, when you stop the nf chain, the server might return 500, but it actually have stopped the nfs, I will look into that, but I don't think it would have any effect on using it.
(optional) Subscribers: << @-mention people who probably care about these changes >>