Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor aws_io_setup class - specifically, the IO values per instance #544

Open
mykaul opened this issue Sep 23, 2024 · 3 comments
Open
Assignees

Comments

@mykaul
Copy link

mykaul commented Sep 23, 2024

My eyes hurt from seeing so many `elif'. See


We should store this in a dictionary, JSON or whatnot. Single location preferably.

@mykaul
Copy link
Author

mykaul commented Sep 23, 2024

Part of this (I should open a separate issue for it!) is that we need to validate the numbers are still real. Ref https://github.com/scylladb/scylla-enterprise/issues/4713#issuecomment-2367619463
We do have a job that is testing a wide range of instances, it should probably compare the results and the hard-coded values (CC @roydahan )

@roydahan
Copy link
Contributor

I created a separate issue for the above comment in qa-tasks.

@roydahan
Copy link
Contributor

My eyes hurt from seeing so many `elif'. See

We should store this in a dictionary, JSON or whatnot. Single location preferably.

Hurt is understatement.
@yaronkaikov a dictionary is the simplest and quickest solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants