Fixed plotting for mixscape.plot_barplot and sccoda.plot_effects_barplot #667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description of changes
mixscape.plot_barplot issue
As reported in #659, the effects bar plot wasn't visible. Adding a simple
plt.tight_layout()
fixed the issue. I also resolved some warnings that occurred during plotting by usingax.set_xticks
instead ofax.set_xticklabels
.sccoda.plot_effects_barplot
Reported in #598 and theislab/single-cell-best-practices#271.
These issues were basically reporting the same problem: there was a bug in the code that caused covariates with only zero effects to be filtered out of the plotting dataframe, even when the
plot_zero_covariate
parameter was set toTrue
(which is the default). This also led to incorrect figure titles. I resolved the issue by removing the line of code causing the bug.For these results:
So far, the generated plot looked like this (one plot missing, wrong titles):
NOW, i.e. after merging this PR, it will look like this: