Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic semver check to CI #527

Open
haerdib opened this issue Apr 12, 2023 · 3 comments
Open

Add automatic semver check to CI #527

haerdib opened this issue Apr 12, 2023 · 3 comments
Labels

Comments

@haerdib
Copy link
Contributor

haerdib commented Apr 12, 2023

According to the comment of @Niederb here: #515 (review):

I recently saw this cargo-semver-checks maybe this would make it easier to identify breaking changes. I haven't tried it though.

I quickly looked into it, but it seems cargo semver, while it does support semver check against github revisions with cli, it does not support this in Github Actions. It seems to only check against crates.io.
To solve this issue we can either

@haerdib haerdib added F3-test fix tests or CI Q0-trivial labels Apr 12, 2023
@Niederb
Copy link
Contributor

Niederb commented Apr 13, 2023

I agree that publishing on crates.io is probably the easiest approach but did you see the section "Does the crate I'm checking have to be published on crates.io?" in the readme?

@haerdib
Copy link
Contributor Author

haerdib commented Apr 13, 2023

Yes, I saw that. But as far as I understood, that's for the cli version. For the GitHub Action one, I didn't find that option. Ofc, one could build the cli version into GHA, but I'm not sure if that's worth it.

@Niederb
Copy link
Contributor

Niederb commented Apr 13, 2023

Yes, I saw that. But as far as I understood, that's for the cli version. For the GitHub Action one, I didn't find that option. Ofc, one could build the cli version into GHA, but I'm not sure if that's worth it.

Ok, I just wanted to mention it. You already gave it more thought than I did 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants