Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve abstract factory example #82

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Mar 25, 2024

No description provided.

That we can add other abstract factory examples.
@BacLuc BacLuc requested a review from langchr86 April 5, 2024 09:54
Copy link
Contributor

@langchr86 langchr86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Found some small improvements.

topics/sw_concepts/sw_concept_slides.md Outdated Show resolved Hide resolved
topics/sw_concepts/sw_concept_slides.md Outdated Show resolved Hide resolved
topics/sw_concepts/sw_concept_slides.md Show resolved Hide resolved
Copy link
Contributor Author

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Label in factory example

Use self drawn stripped down version of the diagram.
@BacLuc BacLuc merged commit 2cf5f49 into scs:main Apr 19, 2024
5 checks passed
@BacLuc BacLuc deleted the abstract-factory-example branch April 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants