Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate words from Russian to other Scribe languages #89

Merged
merged 14 commits into from
Mar 18, 2024

Conversation

shashank-iitbhu
Copy link
Contributor

@shashank-iitbhu shashank-iitbhu commented Mar 4, 2024

Contributor checklist


Description

  • Added translate_words.py to src/scribe_data/extract_transform/languages/Russian/translation
  • This PR can be used as a reference for other translation related issues.
  • This PR can be merged after merging Add translation funcs to utils #88

Related issue

Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Copy link

github-actions bot commented Mar 4, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Signed-off-by: Shashank Mittal <[email protected]>
for item in json_data:
word_list.append(item["word"])

src_lang="Russian"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the src_lang variable to specify the source language for the translations.
Keep the rest of the translate_words.py script unchanged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥 Nice, @shashank-iitbhu :) I'll take a bit more of a look at this, and maybe we can move this to an all caps var at the top. I can handle this myself though 😊

Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
Copy link
Contributor Author

This PR can be tested by running python3 src/scribe_data/extract_transform/languages/Russian/translations/translate_words.py from the project root.

This will also test #88.
cc @andrewtavis @wkyoshida

@andrewtavis
Copy link
Member

Note that the Linux tests don't work if we don't have language-data in the dependencies, which is a bit weird as it should be installed with langcodes... The Mac build in general is pretty broke at this point, as the step to install the PyICU dependencies is what errored now. We can focus on this a bit more after the structure and dependencies are a bit more set :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contributions here, @shashank-iitbhu! Great stuff 😊 I already switched over the English translation process to match the Russian one, and will direct the others to send along their own versions and run it once for the examples. Lots of changes coming along to change the structure, and I'll also finalize the initial docs in #57 as we can't automodule/autodoc a lot of our files as they're scripts :)

@andrewtavis andrewtavis merged commit 0f1a92b into scribe-org:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants