Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting script for english verbs along with formatted data #43

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

SaurabhJamadagni
Copy link
Collaborator

Contributor checklist


Description

Hey @andrewtavis,

PR adds the script for the English verbs. I don't think it's pretty at all. I just wrote some very verbose code that I think works. Could you please check? I am not sure I have covered all the cases. But for the keys we are querying currently, I think it might work. Let me know if there are any changes you want me to push.

The all_conjugations array hasn't been used actually. Left it there just in case we come back if there are any revisions to the query file or just in general have to work with formatting. Can remove if you think it isn't needed.

Related issue

@github-actions
Copy link

github-actions bot commented Aug 27, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis added the GSoC Available for Google Summer of Code participants label Aug 27, 2023
@andrewtavis andrewtavis self-requested a review August 27, 2023 13:46
@andrewtavis
Copy link
Member

Thanks @SaurabhJamadagni! Reading through the blogpost now, and I just applied the GSoC label to all your PRs for here and in Scribe-iOS :)

@SaurabhJamadagni
Copy link
Collaborator Author

Reading through the blogpost now, and I just applied the GSoC label to all your PRs for here and in Scribe-iOS :)

Thank you so much @andrewtavis! I'll add the filter and link it in the blog too :)

@andrewtavis
Copy link
Member

Thank you, @SaurabhJamadagni! 😊

verbs_formatted[infinitive_key]["presSPP"] = verb_vals.get("presFPS", "")
verbs_formatted[infinitive_key]["presTPP"] = verb_vals.get("presFPS", "")

# assigning simpPast to all past keys if available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment that the comment here and other places should be a full sentence. The syntax that we use in Scribe-iOS actually originates in Python :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clean up the code a bit based on your comments, @SaurabhJamadagni, but this is exactly what we needed for the issue! 😊 Will close #39 once I send along the changes :) :)

@andrewtavis andrewtavis merged commit a490dd9 into scribe-org:main Sep 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Available for Google Summer of Code participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants