-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting script for english verbs along with formatted data #43
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you! Maintainer checklist
|
Thanks @SaurabhJamadagni! Reading through the blogpost now, and I just applied the |
Thank you so much @andrewtavis! I'll add the filter and link it in the blog too :) |
Thank you, @SaurabhJamadagni! 😊 |
verbs_formatted[infinitive_key]["presSPP"] = verb_vals.get("presFPS", "") | ||
verbs_formatted[infinitive_key]["presTPP"] = verb_vals.get("presFPS", "") | ||
|
||
# assigning simpPast to all past keys if available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment that the comment here and other places should be a full sentence. The syntax that we use in Scribe-iOS actually originates in Python :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll clean up the code a bit based on your comments, @SaurabhJamadagni, but this is exactly what we needed for the issue! 😊 Will close #39 once I send along the changes :) :)
Contributor checklist
Description
Hey @andrewtavis,
PR adds the script for the English verbs. I don't think it's pretty at all. I just wrote some very verbose code that I think works. Could you please check? I am not sure I have covered all the cases. But for the keys we are querying currently, I think it might work. Let me know if there are any changes you want me to push.
The
all_conjugations
array hasn't been used actually. Left it there just in case we come back if there are any revisions to the query file or just in general have to work with formatting. Can remove if you think it isn't needed.Related issue