Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Estonian data queries-Verbs #294

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

Ekikereabasi-Nk
Copy link
Contributor

@Ekikereabasi-Nk Ekikereabasi-Nk commented Oct 9, 2024

Contributor checklist


Description

This pull request updates the SPARQL queries to ensure comprehensive retrieval of all grammatical features associated with Estonian data queries #227

Purpose of the Update

This update provides:

  • Comprehensive grammatical feature coverage: The updated query now includes all forms, moods, and tenses relevant to Estonian language, ensuring that no important grammatical features are missed.
  • Optimized query structure: The pull request ensures that the query efficiently retrieves all necessary forms and their grammatical features in a single execution.

Testing

The SPARQL queries have been tested on the Wikidata Query Service to ensure accurate retrieval and performance.

Related issue

Copy link

github-actions bot commented Oct 9, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 9, 2024
@Ekikereabasi-Nk
Copy link
Contributor Author

Hi @andrewtavis I'm through with the Estonian adjective, next adverb

@andrewtavis andrewtavis mentioned this pull request Oct 9, 2024
1 task
@andrewtavis
Copy link
Member

@Ekikereabasi-Nk: Give me a moment to do a quick edit of this and send along updated queries. This will give you an idea of how to write further ones :)

The big thing, we don't just want one property being returned as the goal is combinations of properties to get exact forms. As what I did for Polish nouns: https://github.com/scribe-org/Scribe-Data/pull/253/files. I'll do these two and then you can look into other queries after 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @Ekikereabasi-Nk! I'll write in the issue about the work that needs to be done for the verbs query 😊 Great progress here!

@andrewtavis andrewtavis merged commit 7c23e36 into scribe-org:main Oct 9, 2024
3 checks passed
@Ekikereabasi-Nk
Copy link
Contributor Author

Hi @andrewtavis I have studied the SPARQL query from the Polish noun. I have understood what is needed, I'm open to work on any issue concerning the verb query. I'm learning a lot. Thank you.

@andrewtavis
Copy link
Member

Glad to hear, @Ekikereabasi-Nk! This is pretty tough querying here :) Check out the forms that are already being returned by the verbs query and follow the sections I put out. You'll be fine from there 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants