-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Estonian data queries-Verbs #294
Expand Estonian data queries-Verbs #294
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
08aeae6
to
df6422d
Compare
Hi @andrewtavis I'm through with the Estonian adjective, next adverb |
@Ekikereabasi-Nk: Give me a moment to do a quick edit of this and send along updated queries. This will give you an idea of how to write further ones :) The big thing, we don't just want one property being returned as the goal is combinations of properties to get exact forms. As what I did for Polish nouns: https://github.com/scribe-org/Scribe-Data/pull/253/files. I'll do these two and then you can look into other queries after 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @Ekikereabasi-Nk! I'll write in the issue about the work that needs to be done for the verbs query 😊 Great progress here!
Hi @andrewtavis I have studied the SPARQL query from the Polish noun. I have understood what is needed, I'm open to work on any issue concerning the verb query. I'm learning a lot. Thank you. |
Glad to hear, @Ekikereabasi-Nk! This is pretty tough querying here :) Check out the forms that are already being returned by the verbs query and follow the sections I put out. You'll be fine from there 😊 |
Contributor checklist
Description
This pull request updates the SPARQL queries to ensure comprehensive retrieval of all grammatical features associated with Estonian data queries #227
Purpose of the Update
This update provides:
Testing
The SPARQL queries have been tested on the Wikidata Query Service to ensure accurate retrieval and performance.
Related issue