Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created keyword-emoji relationship Python file for Hindi #287

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KesharwaniArpita
Copy link
Contributor

Contributor checklist


Description

This pull request introduces a new feature to generate keyword-emoji relationships from a selection of Hindi words. The implementation allows for the extraction of emojis associated with specified Hindi keywords, facilitating enhanced representation and interaction in applications requiring emoji support.

This enhancement aims to broaden the emoji representation for Hindi speakers and enhance user engagement through more relevant visual communication.

Related issue

Copy link

github-actions bot commented Oct 9, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@KesharwaniArpita KesharwaniArpita changed the title Created keyword-emoji relationship Python file for Basque Created keyword-emoji relationship Python file for Hindi Oct 9, 2024
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 9, 2024
@andrewtavis andrewtavis self-requested a review October 9, 2024 08:11
@andrewtavis
Copy link
Member

Wondering a bit about this PR, @KesharwaniArpita :) Specifically gen_emoji_lexicon doesn't have a filter_language_code argument. Are you on Windows, btw? If so, then you might not be able to test the emoji data to see if these new method can work 🤔

@KesharwaniArpita
Copy link
Contributor Author

Hi, @andrewtavis the use of filter was simply based on the queries. I thought that we might need to distinguish hindi from urdu so I did that. Is there any problem?? I have WSL btw🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants