Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP Error 405 in Hindi Language #286

Closed
wants to merge 5 commits into from
Closed

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 8, 2024

Contributor checklist


Description

Commenting only 3 lines out of 4 on top of the file, fix's the HTTP Error 405: Method Not Allowed.

CC: @andrewtavis @SethiShreya

Copy link

github-actions bot commented Oct 8, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 8, 2024 22:58
@andrewtavis
Copy link
Member

Hey @axif0 👋 No stress on this, but I'm going to close this as the formatting is going to be having an overhaul soon. I need to do #142 soon that will change how formatting works entirely. Once this is done we can look into this again, but I'd prefer to not have to navigate more legacy formatting files than are already there.

Hope this makes sense, and again no stress!

@andrewtavis andrewtavis closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants