Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding query_verbs.sparql for kurmanji #272

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

Khushalsarode
Copy link
Contributor

@Khushalsarode Khushalsarode commented Oct 7, 2024

Contributor checklist

Description

  • The query has been executed & tested on wikidata editor
  • Developed a SPARQL query to retrieve all Kurmanji (Q36163) verbs and their grammatical forms from Wikidata.
  • Extracts lexeme IDs, verb forms, and various grammatical features including infinitive, gerund, accusative, and ergative.
  • optional clauses to include additional forms such as adverbial, absolute construction, and participle

Issue reference

@andrewtavis

Copy link

github-actions bot commented Oct 7, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 7, 2024 22:06
}

ORDER BY ASC (?lexemeID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the extra spacing, @Khushalsarode? And also this ORDER BY is not necessary here as we don't need the results in a given order. This will end up just slowing the query down a bit :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done as per requested! 👍

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @Khushalsarode :) Ultimately I simplified the data down as there there don't appear to be any forms on the verbs, so this is one we'll need to do later. Nice touch on filtering the language to ku though 😊

@andrewtavis andrewtavis merged commit dc2dbac into scribe-org:main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants