Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the query for extracting Adverbs, Proper Nouns and Personal Pronouns in Esperanto #270

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

KesharwaniArpita
Copy link
Contributor

Contributor checklist


Description

This PR introduces a new query for extracting the following parts of speech in Esperanto from Wikidata:

  1. Adverbs
  2. Proper Nouns
  3. Personal Pronouns

These categories were prioritized because the remaining parts of speech (conjunctions, prepositions, postpositions, and articles) had insufficient data (<10 units). By focusing on adverbs, proper nouns, and personal pronouns, we ensure that the data extraction yields meaningful and usable results for further analysis.

The queries have been tested on https://query.wikidata.org/

Related issue

Copy link

github-actions bot commented Oct 7, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
@andrewtavis andrewtavis self-requested a review October 7, 2024 18:22
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @KesharwaniArpita! Your PR actually made it clear that the comment in noun queries was unclear that we're getting proper nouns as well. So I removed that query, but now the others indicate that we are getting nouns and proper nouns 😊

Appreciate all your work! :)

@andrewtavis andrewtavis merged commit b25dab2 into scribe-org:main Oct 9, 2024
3 checks passed
@KesharwaniArpita KesharwaniArpita deleted the ArpitaContributions branch October 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants