-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand polish verbs query 233 #253
Expand polish verbs query 233 #253
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Hey @Ekikereabasi-Nk 👋 Would you be able to clean up the PR a little bit? I'm seeing a couple of things on first glance:
If need be, you can just copy the current version of these files on GitHub and paste them in your local branch to revert the changes :) |
Thanks for the feedback @andrewtavis |
582397f
to
4a8fcce
Compare
4a8fcce
to
17964a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andrewtavis I have removed the changes to the Urdu folder that were added from my other pull request. Please let me know if you need me to make any other changes or if you have any questions about this. Thanks
Hi @andrewtavis it there a problem with this pull request? I will like to know where the problem is, so I can fix it. Thank you |
Nothing wrong that I can report, @Ekikereabasi-Nk :) I still just need some time to check it as it's a bit more involved. I'll let you know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this query get it to where it needs to be @Ekikereabasi-Nk :) Big thing to remember in all of this is that for every form we see on Wikidata, we need to account for all of the properties that make up that form. Then at the end we get an individual row for each form rather than duplicates 😊
Thanks so much for the work here!
Alright @andrewtavis I will take note in my next queries and commit. Thank you |
Contributor checklist
###Description
This pull request expands the Polish verbs functionality within Scribe-Data by adding two new SPARQL query files designed to retrieve Polish verbs and their grammatical forms from Wikidata.
Changes Made:
Renamed Query File:
query_verbs.sparql
has been renamed toquery_verbs_1.sparql
.New SPARQL Queries:
query_verbs_1.sparql
: This query retrieves Polish verbs and their common grammatical forms such as infinitive, imperative, indicative, and various tenses (past, future).query_verbs_2.sparql
: This query is designed to retrieve Polish verbs with extended grammatical forms, including feminine, masculine, and neuter variations, as well as participles and aspectual distinctions (imperfective and perfective).Testing
Both queries were tested using the Wikidata Query Service.
Related issue