Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand polish verbs query 233 #253

Merged

Conversation

Ekikereabasi-Nk
Copy link
Contributor

Contributor checklist


###Description

This pull request expands the Polish verbs functionality within Scribe-Data by adding two new SPARQL query files designed to retrieve Polish verbs and their grammatical forms from Wikidata.

Changes Made:

  1. Renamed Query File:

    • The existing file query_verbs.sparql has been renamed to query_verbs_1.sparql.
  2. New SPARQL Queries:

    • query_verbs_1.sparql: This query retrieves Polish verbs and their common grammatical forms such as infinitive, imperative, indicative, and various tenses (past, future).
    • query_verbs_2.sparql: This query is designed to retrieve Polish verbs with extended grammatical forms, including feminine, masculine, and neuter variations, as well as participles and aspectual distinctions (imperfective and perfective).

Testing

Both queries were tested using the Wikidata Query Service.

Related issue

Copy link

github-actions bot commented Oct 5, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 5, 2024 18:51
@andrewtavis
Copy link
Member

Hey @Ekikereabasi-Nk 👋 Would you be able to clean up the PR a little bit?

I'm seeing a couple of things on first glance:

  • There are more English verbs being added to scribe_data_json_export, which we don't need in this PR
  • There's also changes to the Urdu directory from your other PR, which would be great to remove from this one
  • Can we also revert the changes to the load/update_files/total_data.json file?

If need be, you can just copy the current version of these files on GitHub and paste them in your local branch to revert the changes :)

@Ekikereabasi-Nk
Copy link
Contributor Author

Thanks for the feedback @andrewtavis

Copy link
Contributor Author

@Ekikereabasi-Nk Ekikereabasi-Nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewtavis I have removed the changes to the Urdu folder that were added from my other pull request. Please let me know if you need me to make any other changes or if you have any questions about this. Thanks

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
@Ekikereabasi-Nk
Copy link
Contributor Author

Hi @andrewtavis it there a problem with this pull request? I will like to know where the problem is, so I can fix it. Thank you

@andrewtavis
Copy link
Member

Nothing wrong that I can report, @Ekikereabasi-Nk :) I still just need some time to check it as it's a bit more involved. I'll let you know!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this query get it to where it needs to be @Ekikereabasi-Nk :) Big thing to remember in all of this is that for every form we see on Wikidata, we need to account for all of the properties that make up that form. Then at the end we get an individual row for each form rather than duplicates 😊

Thanks so much for the work here!

@andrewtavis andrewtavis merged commit d141e0e into scribe-org:main Oct 9, 2024
3 checks passed
@Ekikereabasi-Nk
Copy link
Contributor Author

Alright @andrewtavis I will take note in my next queries and commit. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants