Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path fix #252

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Path fix #252

merged 2 commits into from
Oct 5, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 5, 2024

Contributor checklist


Description

In windows the path works even if it contains spaces. Like it can handle "New folder" now. Previously it shows error like-

python3: can't open file 'E:\New': [Errno 2] No such file or directory

Copy link

github-actions bot commented Oct 5, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@axif0
Copy link
Contributor Author

axif0 commented Oct 5, 2024

If someone in windows faced like ModuleNotFoundError: No module named 'scribe_data'
You can resolve it by setting the PYTHONPATH. Please use like set PYTHONPATH=E:\New folder\Scribe-Data\src. Make sure to replace E:\New folder\Scribe-Data\src with the actual path to your scribe-data files as it's different.

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 5, 2024
@andrewtavis andrewtavis self-requested a review October 5, 2024 18:15
@andrewtavis
Copy link
Member

I felt like moving the path to a separate variable was a bit cleaner, @axif0 :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always for finding bugs and fixing them so quickly, @axif0!

@andrewtavis andrewtavis merged commit deaf9b7 into scribe-org:main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants