-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Danish verb query #249
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, @catreedle :) I removed select distinct and I don't think it'll do much to avoid the repeat rows being returned and slows the query down a bit. We can revisit it if need be later 😊
Thank you, @andrewtavis! Out of curiosity, how do you decide when to use SELECT vs. SELECT DISTINCT? Is it by comparing the number of rows each returns, or are there other considerations? |
Select distinct will add an extra processing step to make sure all things are unique. Generally for this we can expect things to be unique, or if they aren't then there's a problem with the modeling that means we're getting multiple values back for certain form combinations. Big thing is to not use extra resources for the distinct of not necessary :) |
Contributor checklist
Description
This pull request expands the Danish verb query in src/scribe_data/language_data_extraction/Danish/verbs/query_verbs.sparql by adding more conjugation forms available on Wikidata.
The forms included in this update are:
The query has been tested and runs correctly on the Wikidata Query Service
Related issue