Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nigerian-pidgin): add SPARQL query for verbs #246

Conversation

DeleMike
Copy link
Contributor

@DeleMike DeleMike commented Oct 4, 2024

  • Create new directory structure for Nigerian Pidgin
  • Add basic SPARQL query to extract Nigerian Pidgin verb lemmas from Wikidata

This PR introduces initial support for Nigerian Pidgin verb data extraction, providing a foundation for gathering basic linguistic information for this language.

Contributor checklist


Description

Related issue

- Create new directory structure for Nigerian Pidgin
- Add basic SPARQL query to extract Nigerian Pidgin verb lemmas from Wikidata
Copy link

github-actions bot commented Oct 4, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@DeleMike
Copy link
Contributor Author

DeleMike commented Oct 4, 2024

Hi @andrewtavis👋🏾, here is the PR that adds verbs query for Nigerian Pidgin.

It is related to #220.

Questions:

  1. Do we add nouns query in this PR or keep it lean like this for now?

  2. I saw that there is a directory called:

scribe_data_json_export/English

I believe that is for English but do we need to create something similar for Pidgin_Nigerian? How would that work?

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this a bit based on our conversations, @DeleMike, and I think having a sub-directory structure for these sorts of languages makes sense so that we can have dialects structured in a similar way. What I mean by this is having the different types of Norwegian in a single directory, or for something like Portuguese we could have Portuguese and Brazilian variants :) I'll merge as it is, but also let me know what your thoughts are on this! We can maybe add more versions of Pidgin into this new directory?

@andrewtavis andrewtavis merged commit e9e3a65 into scribe-org:main Oct 5, 2024
3 checks passed
@DeleMike
Copy link
Contributor Author

DeleMike commented Oct 5, 2024

hi @andrewtavis, this makes sense! I was going through the updated code and this will make sure we have things in uniform.

I think your update is what we should go for!

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants