-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing IncompleteRead issue #221
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Hey @axif0 👋 Can you look into the merge conflicts here? :) One thing as well: I'm a bit confused why this is necessary as we already had something to retry queries, but maybe the old one wasn't working 🤔 You can see the old version here. Do you want to fix the conflicts and combine the methods as you see fit? |
@andrewtavis While running all language querying verbs and nouns, I got the |
No stress whatsoever, @axif0! It's an interesting idea. I'm just wondering if maybe your incomplete read is a more specific implementation of what I was doing with mine. In that case, maybe you could do a slight edit to combine them? :) |
Contributor checklist
Description
Adding this retry logic, we can handle temporary network issues or server-side problems that cause the IncompleteRead error. The code will automatically retry the request a few times before giving up.
Related issue