Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing IncompleteRead issue #221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 3, 2024

Contributor checklist


Description

Adding this retry logic, we can handle temporary network issues or server-side problems that cause the IncompleteRead error. The code will automatically retry the request a few times before giving up.

Related issue

Copy link

github-actions bot commented Oct 3, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 3, 2024 21:28
@andrewtavis
Copy link
Member

Hey @axif0 👋 Can you look into the merge conflicts here? :) One thing as well: I'm a bit confused why this is necessary as we already had something to retry queries, but maybe the old one wasn't working 🤔 You can see the old version here. Do you want to fix the conflicts and combine the methods as you see fit?

@axif0
Copy link
Contributor Author

axif0 commented Oct 7, 2024

@andrewtavis While running all language querying verbs and nouns, I got the IncompleteRead error specifically. After that I ran again and no error. I thought if the error occurs then try few times to reconnect. Maybe some network connection issue from my end. Although you made several changes in query_data.py. I don't sure exactly. In future if we face the issue then we can ping here. Sorry if you find it irrelevant.

@andrewtavis
Copy link
Member

No stress whatsoever, @axif0! It's an interesting idea. I'm just wondering if maybe your incomplete read is a more specific implementation of what I was doing with mine. In that case, maybe you could do a slight edit to combine them? :)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants