-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more bug in CLI - Interactive Learning module #204
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
This change in |
Minor changes in 4cbc502 as I felt like the CLI was a bit too verbose. It was saying it was going to do something multiple times. The path for exporting JSONs also wasn't working properly as it needs to be absolute. @mhmohona, do you want to take a look at some of these changes and we can discuss how to go from here? Multiple data types is also working, so we're generally good in those regards :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely some progress on interactive mode for this one, @mhmohona! Thanks for the continued efforts 😊 I'm thinking we're really close on it and the cli in general :)
Contributor checklist
Description
Related issue