Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance sexp handling of generic subsystems #6409

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Goober5000
Copy link
Contributor

  1. Since we already handle <all engines> and <all turrets>, it's simple to extend this to all generic subsystems of any type
  2. Add an <all subsystems> case for handling every subsystem on a ship
  3. Add some compiler directives to enforce preconditions for subsystem type #defines

1. Since we already handle `<all engines>` and `<all turrets>`, it's simple to extend this to all generic subsystems of any type
2. Add an `<all subsystems>` case for handling every subsystem on a ship
3. Add some compiler directives to enforce preconditions for subsystem type `#define`s
@Goober5000 Goober5000 added enhancement A new feature or upgrade of an existing feature to add additional functionality. sexps A feature or issue related to SEXPs labels Nov 3, 2024
Copy link
Member

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly useful and looks good to me

@Goober5000 Goober5000 merged commit ad08452 into scp-fs2open:master Nov 11, 2024
16 checks passed
@Goober5000 Goober5000 deleted the generic_all_subsystems branch November 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or upgrade of an existing feature to add additional functionality. sexps A feature or issue related to SEXPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants