Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify options popup message text #6355

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Clarify options popup message text #6355

merged 1 commit into from
Sep 20, 2024

Conversation

MjnMixael
Copy link
Contributor

Make this popup not feel like an error because it isn't one but still nudge the player to verify their settings. Fixes #6351

wookieejedi
wookieejedi approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change, and I suggest this be part of the next RC

@wookieejedi wookieejedi added the cleanup A modification or rewrite of code to make it more understandable or easier to maintain. label Sep 16, 2024
@TRBlount TRBlount merged commit 466995a into scp-fs2open:master Sep 20, 2024
16 checks passed
@MjnMixael MjnMixael deleted the adjust_options_message branch September 20, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wookieejedi wookieejedi wookieejedi approved these changes

Assignees
No one assigned
Labels
cleanup A modification or rewrite of code to make it more understandable or easier to maintain.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should the game settings menu be enabled by default? (24.2)
3 participants
@MjnMixael @wookieejedi @TRBlount