allow explicitly empty sounds #6352
Conversation
Make sounds that are specified as "empty" or "none" in sounds.tbl ineligible for treatment as placeholder sounds. Resolves scp-fs2open#6350.
|
This does resolve that specific crop of warnings in my own testing. I haven't yet confirmed that the affected sound indexes actually behave properly in terms of what sounds they play(nor have I confirmed that they misbehave without this PR, for that matter) and I'd like to do that before getting out the LGTM stamp. I should be able to do that this weekend. I'm also concerned by the growing code complexity with proliferating special cases, tying into the concerns about the general sound overhaul I've documented in #6354. I'd prefer to have a general consensus on all that before approving this, on my part, but I won't put a changes-required review over that. |
There was a problem hiding this comment.
In combination with #6356, reported to work as expected on MediaVPs, retail, BtA, and FotG, Scroll, Inferno, BP, and Warmachine. Following discussion this looks good to me and also works in my tests.
Make sounds that are specified as "empty" or "none" in sounds.tbl ineligible for treatment as placeholder sounds. Resolves #6350.