-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built-in xstrs for SCP-added controls #5627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this on hold until review for #5622 is covered.
Already altered taking that PR into account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the final version of #5622 ready, the IDs need to be shifted back so 1774 is occupied. XSTR_SIZE can be left as is here.
a477051
to
a2f1638
Compare
done |
These controls, added by SCP were never given XSTRs for localization. This PR adds them. Fixes #4611
Note that built-in xstrs were required to be sequential and fit within a fixed sized array at the time that bug was reported. That is no longer the case and a deep dive to find unused xstr IDs is not necessary anymore.