Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in xstrs for SCP-added controls #5627

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

MjnMixael
Copy link
Contributor

These controls, added by SCP were never given XSTRs for localization. This PR adds them. Fixes #4611

  • 1799, Glide When Pressed
  • 1800, Toggle Gliding
  • 1801, Cycle Primary Weapon Firing Rate
  • 1802, Top-Down View
  • 1803, Target Padlock View
  • 1804, Toggle Auto Pilot
  • 1805, Cycle Nav Points
  • 1806, Toggle HUD Drop Shadows

Note that built-in xstrs were required to be sequential and fit within a fixed sized array at the time that bug was reported. That is no longer the case and a deep dive to find unused xstr IDs is not necessary anymore.

@wookieejedi wookieejedi added controls A feature or issue related to input devices or actions controlled/triggered by them localization / translation (XSTR) A feature or issue related to language localization and translations. labels Sep 29, 2023
Copy link
Contributor

@TRBlount TRBlount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this on hold until review for #5622 is covered.

@MjnMixael
Copy link
Contributor Author

Putting this on hold until review for #5622 is covered.

Already altered taking that PR into account

Copy link
Contributor

@TRBlount TRBlount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the final version of #5622 ready, the IDs need to be shifted back so 1774 is occupied. XSTR_SIZE can be left as is here.

@MjnMixael
Copy link
Contributor Author

With the final version of #5622 ready, the IDs need to be shifted back so 1774 is occupied. XSTR_SIZE can be left as is here.

done

@TRBlount TRBlount merged commit 7ef70f6 into scp-fs2open:master Oct 19, 2023
10 of 14 checks passed
@MjnMixael MjnMixael deleted the new_controls_xstrs branch October 19, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls A feature or issue related to input devices or actions controlled/triggered by them localization / translation (XSTR) A feature or issue related to language localization and translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New controls not translatable
4 participants