Bugfix: Crash while saving when hosts was disabled and enabled together #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2017 20:49
When the HostsFile was disabled (hosts.disabled file exists and no hosts file), saving would lead the program to create a new hosts file. If the user wanted to disable the HostsFile the again, the program would crash. Now before saving the program checks if there exists a hosts.disabled file and if yes, tells the user that he/she needs to enable the HostsFile before editing entries.
Added an additional check to make sure that the program doesn't crash when both enabled and disabled HostsFile exist at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the HostsFile was disabled (hosts.disabled file exists and no hosts file), saving would lead the program to create a new hosts file. If the user wanted to disable the HostsFile the again, the program would crash.
Now before saving the program checks if there exists a hosts.disabled file and if yes, tells the user that he/she needs to enable the HostsFile before editing entries.