Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate BiBTeX output with a LaTeX, BiBTeX, LaTeX cycle that runs automatically as part of the GitHub Actions #313

Open
simsong opened this issue Jul 10, 2022 · 5 comments

Comments

@simsong
Copy link
Contributor

simsong commented Jul 10, 2022

Validate BiBTeX output with a LaTeX, BiBTeX, LaTeX cycle that runs automatically as part of the GitHub Actions.

This is the only real way to validate that everything works.

@MiWeiss
Copy link
Collaborator

MiWeiss commented Jul 16, 2022

Assigned the issue to @simsong (discussed in another thread). Thanks for taking this over. This looks like a great reliability smokescreen!

Just to be sure we're talking about the same thing: You intend to make sure that files written using the writer are valid, right? I guess that leaves some wiggle-room w.r.t. what's considered a bug, based on the input you feed it (garbage in / garbage out). It also raises the question of how we should handle potential problems identified by the workflow: I guess we'd have to open issues for each one of them and, until all of them are fixed, not enforce the new workflow's pass (as otherwise, no PRs could be merged until all of this is fixed).

Looking forward to the contributions, I think this might be very useful.

Note: These tests would have to run in a separate workflow (not in the unit test one). They probably run slower and need more and different dependencies.

@MiWeiss
Copy link
Collaborator

MiWeiss commented May 27, 2023

@simsong V2 (beta) which fixes many of the issues of v1 is now available on the main branch.

Are you still interested in contributing a test suite as described in this issue? If so, I think it would make sense to port it directly to v2. Otherwise, I will close this issue as stale.

@simsong
Copy link
Contributor Author

simsong commented May 27, 2023

@MiWeiss Yes, I remain interested in contributing a test suite. Test suites are important. it could also be integrated with GitHub Actions, which I could also do.

@MiWeiss
Copy link
Collaborator

MiWeiss commented May 27, 2023

Great, I am happy to keep this open then :-) Thanks!

@simsong
Copy link
Contributor Author

simsong commented May 27, 2023

So it looks like I should check out v2 beta. I'll do that and put this on my task list. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants