Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel.packages cannot point to a module? #888

Open
LecrisUT opened this issue Sep 3, 2024 · 1 comment
Open

wheel.packages cannot point to a module? #888

LecrisUT opened this issue Sep 3, 2024 · 1 comment

Comments

@LecrisUT
Copy link
Collaborator

LecrisUT commented Sep 3, 2024

I've encountered this when trying to write a minimal test setup where I didn't care about placing everything in a proper package, but wanted to write them dirty as modules, i.e.:

$ tree
.
├── CMakeLists.txt
├── hello.py
├── main.cpp -> ../main.cpp
└── pyproject.toml
[build-system]
requires = ["scikit-build-core", "main-project-that-i-am-testing-the-packaging-for"]
build-backend = "scikit_build_core.build"

[project]
name = "simple-test-for-the-CMake-find_package"
version = "0.0.0"

[project.scripts]
run_test = "hello:run"

[tool.scikit-build]
wheel.install-dir = "simple_test"
wheel.packages = ["hello"]

And in the test I want to simply run the executable. I would probably remove the wheel.install-dir so that it installs directly into SKBUILD_SCRIPTS_DIR, but just a weird setup where I got this to break 🤷

@henryiii
Copy link
Collaborator

henryiii commented Sep 3, 2024

Hmm, no, it's only directories (packages). If all it is is a wrapper, you should install to SKBUILD_SCRIPTS_DIR (you need to use experimental=True + wheel.install-dir = "/scripts" or install to SKBUILD_SCRIPTS_DIR, though). I've wondered in the past if we could set the bin install dir for users but we don't currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants