Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual excludes with manual includes #858

Open
henryiii opened this issue Aug 13, 2024 · 1 comment
Open

Manual excludes with manual includes #858

henryiii opened this issue Aug 13, 2024 · 1 comment

Comments

@henryiii
Copy link
Collaborator

I think manual excludes should likely override manual includes? That is, sdist.include = “*” can’t be overridden and includes everything. I think it should only override gitignores and maybe the global ignore list, but not the sdist.exclude list. We should see how it’s being used first.

Supporting an “all” source option also might help if people want to avoid gitignores.

@LecrisUT
Copy link
Collaborator

It is tricky because you can have the opposite as well. There was an idea on PEP639 about allowing gitignore style syntax, specifically the ! operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants