Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version hashes from jitpack are detected as main classes #52

Open
ctrueden opened this issue Aug 13, 2019 · 0 comments
Open

Version hashes from jitpack are detected as main classes #52

ctrueden opened this issue Aug 13, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@ctrueden
Copy link
Member

With the shell script version of jgo:

$ jgo -U -v sc.iview:sciview:a7ca388
[INFO] Artifact:
[INFO] - groupId    = sc.iview
[INFO] - artifactId = sciview
[INFO] - version    = RELEASE
[INFO] - classifier = <none>
[INFO] Workspace = /Users/curtis/.jgo/sc.iview/sciview/a7ca388
++ mvn -B -U -f /Users/curtis/.jgo/sc.iview/sciview/a7ca388/pom.xml dependency:resolve
+ ln -s /Users/curtis/.m2/repository/com/miglayout/miglayout/3.7.4/miglayout-3.7.4-swing.jar /Users/curtis/.jgo/sc.iview/sciview/a7ca388
... lots more linking ...
+ java -cp '/Users/curtis/.jgo/sc.iview/sciview/a7ca388/*' a7ca388
Error: Could not find or load main class a7ca388

The version is erroneously detected as RELEASE, with main class a7ca388. This is probably because when given an x:y:z triple, we need to detect whether z is a main class or a version number. That heuristic needs to be tweaked to work properly with jitpack version hashes.

@ctrueden ctrueden added this to the 1.0.0 milestone Aug 13, 2019
@ctrueden ctrueden self-assigned this Aug 13, 2019
@ctrueden ctrueden changed the title Hash-versioned endpoints from jitpack are not detected as g:a:v Version hashes from jitpack are detected as main classes Aug 13, 2019
@ctrueden ctrueden added the bug label Nov 11, 2020
@ctrueden ctrueden modified the milestones: 1.0.0, unscheduled Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant