Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell script behaves badly when repeatedly executing endpoint with no mainClass #42

Open
ctrueden opened this issue Jun 28, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@ctrueden
Copy link
Member

Example:

$ jgo org.scijava:scijava-common
No main class given, and none found.
$ jgo org.scijava:scijava-common
ln: /Users/curtis/.jgo/org.scijava/scijava-common/parsington-1.0.3.jar: File exists
cp: /Users/curtis/.jgo/org.scijava/scijava-common/parsington-1.0.3.jar and /Users/curtis/.m2/repository/org/scijava/parsington/1.0.3/parsington-1.0.3.jar are identical (not copied).
Cannot copy '/Users/curtis/.m2/repository/org/scijava/parsington/1.0.3/parsington-1.0.3.jar' into jgo workspace '/Users/curtis/.jgo/org.scijava/scijava-common'
No main class given, and none found.

I think this happens because jgo looks for the existence of a mainClass stub file, and acts based on that. But if no main was found for an endpoint, no mainClass gets written. Perhaps we should write an empty one and then test for content instead?

@ctrueden ctrueden added the bug label Jun 28, 2019
@ctrueden ctrueden added this to the 1.0.0 milestone Jun 28, 2019
@ctrueden ctrueden self-assigned this Jun 28, 2019
@ctrueden
Copy link
Member Author

@hanslovsky and I decided the fix will be to behave as though -u is passed whenever no mainClass is present.

@ctrueden ctrueden modified the milestones: 1.0.0, unscheduled Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant