Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange SPEC sections #256

Merged

Conversation

jarrodmillman
Copy link
Member

As discussed in the last steering committee meeting. See #247.

@jarrodmillman
Copy link
Member Author

pre-commit.ci autofix

Copy link
Member

@stefanv stefanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review of the SPEC 1 refactoring. Some minor comments, but 👍 overall. Thanks!

spec-0001/index.md Outdated Show resolved Hide resolved
spec-0001/index.md Outdated Show resolved Hide resolved
spec-0001/index.md Show resolved Hide resolved
spec-0001/index.md Show resolved Hide resolved
spec-0001/index.md Outdated Show resolved Hide resolved
@jarrodmillman
Copy link
Member Author

pre-commit.ci autofix

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like this new structure, I think it brings clarity and looking at SPEC1, I think it's now easier to parse and understand.

@jarrodmillman jarrodmillman merged commit e51b1f5 into scientific-python:main Aug 3, 2023
1 check passed
@jarrodmillman jarrodmillman deleted the rearrange-spec-sections branch August 3, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants