You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having been working on #192, it occurred to me that it would be helpful if, for the purposes of testing, we decided on a few standard screen sizes or aspect ratios to test the site's appearance with. For example, using the Chrome tools, one can view a site in the equivalent of various devices:
Otherwise, we risk our changes being tested inconsistently, potentially resulting in some "whack-a-mole"-style development. Also, this might allow us to set up a system to automatically preview changes in certain viewports when a PR is made.
Agreed. I think that having a few designated targets will help us measure our progress, as well.
I'll do a bit of research about common screen sizes/ratios to target, trying to get an average for each device type.
@stefanv@jarrodmillman I could also look into setting up a headless browser to automatically take screenshots for each targeted device for PRs so they could be evaluated more efficiently. What do you think?
Hi,
Having been working on #192, it occurred to me that it would be helpful if, for the purposes of testing, we decided on a few standard screen sizes or aspect ratios to test the site's appearance with. For example, using the Chrome tools, one can view a site in the equivalent of various devices:
etc.
Otherwise, we risk our changes being tested inconsistently, potentially resulting in some "whack-a-mole"-style development. Also, this might allow us to set up a system to automatically preview changes in certain viewports when a PR is made.
@jarrodmillman @stefanv What do you think? Thanks.
The text was updated successfully, but these errors were encountered: