Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -s <search_query> command line argument #511

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

mark-henry
Copy link
Contributor

@mark-henry mark-henry commented Aug 14, 2024

Specify -q instead of -l to use the url of the top result.

In my testing I did experience some rate limiting.

Tests: You will probably want to create a different playlist to use for testing, or make https://soundcloud.com/one-thousand-and-one/sets/test-playlist/s-ZSLfNrbPoXR public so that the search can find it.

I will port this to develop some other day

@mark-henry mark-henry changed the title Add -s <search_term> command line argument Add -q <search_query> command line argument Aug 14, 2024
@7x11x13
Copy link
Member

7x11x13 commented Aug 14, 2024

Thanks for the PR! Something which I think might be useful is to add the ability to specify whether to search for tracks/users/playlists.

@mark-henry
Copy link
Contributor Author

Does this request block merging, or is it just an idea for future work?

@7x11x13
Copy link
Member

7x11x13 commented Aug 14, 2024

Just an idea for future work

@7x11x13 7x11x13 merged commit e06cc9c into scdl-org:master Aug 14, 2024
3 checks passed
@mark-henry mark-henry changed the title Add -q <search_query> command line argument Add -s <search_query> command line argument Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants