INTEGRATION [PR#5626 > development/8.7] Fixup on deleteObject #5629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced by #5580 we now do send a requestContext with no specific resource instead of "null", which results in a policy evaluation error. As we get an implicit deny for the requestType "objectDelete", cause the processed result to be false , thus sending an empty array of objects to vault , resulting in a deny even when the policy allows the action on specific objects. Linked Issue : https://scality.atlassian.net/browse/CLDSRV-555
…mp/octopus/w/7.70/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
… into tmp/octopus/w/8.6/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
…into tmp/octopus/w/8.7/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
Merged
…mp/octopus/w/7.70/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
… into tmp/octopus/w/8.6/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
…into tmp/octopus/w/8.7/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #5626.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.7/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix, please follow thisprocedure:
$ git fetch $ git checkout w/8.7/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.7/bugfix/CLDSRV-555-deleteObjects-policy-eval-fixPlease always comment pull request #5626 instead of this one.