Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style and spacing for form elements #4238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Make sure every form element follow the guidelines

The following changes were made:

Guidelines

  • Legend: BodyStrong - NeutralTextStrong  
  • Description: BodySmall - NeutralTextStrong  
  • Label:
LARGE = BodyStrong - NeutralTextStrong  
SMALL = BodySmallStrong - NeutralTextStrong  
  • Placeholder: 
LARGE = Body - NeutralTextWeak
SMALL = BodySmall - NeutralTextWeak
  • Value:
LARGE = Body - NeutralTextStrong  
SMALL = BodySmall - NeutralTextStrong  
  • Helper:  Caption - NeutralTextWeak
  • Error: Caption - DangerText  
  • Success:  Caption - SuccesText  
  • Spacing: must have the same spacing (ex of problem: helpers at 4px for inputs but 8px for checkbox)

& use Icons correctly for those component (import icon directly instead of legacy)

@lisalupi lisalupi self-assigned this Sep 13, 2024
@lisalupi lisalupi requested review from DorianMaliszewski and removed request for a team September 13, 2024 15:12
Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 15e5689

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/form Patch
@ultraviolet/ui Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.03%. Comparing base (1152b39) to head (15e5689).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/NumberInputV2/index.tsx 88.88% 1 Missing ⚠️
packages/ui/src/components/Radio/index.tsx 50.00% 1 Missing ⚠️
packages/ui/src/components/RadioGroup/index.tsx 50.00% 1 Missing ⚠️
packages/ui/src/components/SelectInputV2/index.tsx 0.00% 1 Missing ⚠️
packages/ui/src/components/TagInput/index.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4238      +/-   ##
==========================================
+ Coverage   86.99%   87.03%   +0.04%     
==========================================
  Files         315      315              
  Lines       11354    11356       +2     
  Branches     3108     3066      -42     
==========================================
+ Hits         9877     9884       +7     
+ Misses       1477     1472       -5     
Files with missing lines Coverage Δ
packages/ui/src/components/Checkbox/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/CheckboxGroup/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/DateInput/index.tsx 100.00% <100.00%> (ø)
...ages/ui/src/components/SelectInputV2/SelectBar.tsx 60.65% <100.00%> (+0.49%) ⬆️
...es/ui/src/components/SelectableCardGroup/index.tsx 96.66% <100.00%> (ø)
...ages/ui/src/components/Slider/components/Label.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Slider/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/TextArea/index.tsx 92.59% <100.00%> (+1.12%) ⬆️
packages/ui/src/components/TextInputV2/index.tsx 89.34% <100.00%> (-0.09%) ⬇️
packages/ui/src/components/Toggle/index.tsx 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1152b39...15e5689. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants