Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quoting type in a pattern doesn't work with higher-kinded types #10864

Closed
IndiscriminateCoding opened this issue Dec 19, 2020 · 1 comment · Fixed by #17362
Closed

Quoting type in a pattern doesn't work with higher-kinded types #10864

IndiscriminateCoding opened this issue Dec 19, 2020 · 1 comment · Fixed by #17362
Labels
area:metaprogramming:quotes Issues related to quotes and splices itype:language enhancement
Milestone
3.4.0

Comments

@IndiscriminateCoding
Copy link

IndiscriminateCoding commented Dec 19, 2020 •
edited
Loading

Minimized code

T.scala:

import scala.quoted._

case class T(t: Type[_])

object T {
  def impl[T <: AnyKind](using tt: Type[T])(using Quotes): Expr[Unit] = {
    val t = T(tt)
    t.t match
      case '[x] => println("ok")
      case _ => println("not ok :(")
    '{}
  }

  inline def run[T <: AnyKind] = ${ impl[T] }
}

Run.scala:

@main
def run = T.run[List]

Output

not ok :(

Expectation

It is possible to match higher-kinded type in a macro quotation pattern.
Closed
@nicolasstucki nicolasstucki mentioned this issue May 12, 2021
Closed
@nicolasstucki nicolasstucki mentioned this issue Aug 3, 2021
Closed
@Katrix Katrix mentioned this issue Aug 12, 2021
Draft
7 tasks
@Katrix
Copy link
Contributor

Katrix commented Aug 20, 2021

Was told to mention that the Shapeless 2 port to Scala 3 needs this

milessabin/shapeless#1200

@nicolasstucki nicolasstucki added area:metaprogramming:quotes Issues related to quotes and splices and removed area:metaprogramming labels Jun 2, 2022
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 16, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
1c41faa 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.

Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; `x`] =>
case '[type x; Map[`x`, `x`]] =>
case '[type x <: List[Any]; `x`] =>
case '[type f[X]; `f`] =>
case '[type f <: AnyKind; `f`] =>
```

Fixes scala#10864
Fixes scala#11738
@nicolasstucki nicolasstucki mentioned this issue Feb 16, 2023
Closed
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 17, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
9268309 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.

Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; `x`] =>
case '[type x; Map[`x`, `x`]] =>
case '[type x <: List[Any]; `x`] =>
```

In combination with scala#16907 it would also allow
```
case '[type f[X]; `f`] =>
case '[type f <: AnyKind; `f`] =>
```
and therefore solve scala#10864 and scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 17, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
b0b3159 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.

Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; `x`] =>
case '[type x; Map[`x`, `x`]] =>
case '[type x <: List[Any]; `x`] =>
```

In combination with scala#16907 it would also allow
```scala
case '[type f[X]; `f`] =>
case '[type f <: AnyKind; `f`] =>
```
and therefore solve scala#10864 and scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 17, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
bfae7cf 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.

Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; `x`] =>
case '[type x; Map[`x`, `x`]] =>
case '[type x <: List[Any]; `x`] =>
```

In combination with scala#16907 it would also allow
```scala
case '[type f[X]; `f`] =>
case '[type f <: AnyKind; `f`] =>
```
and therefore solve scala#10864 and scala#11738
@nicolasstucki nicolasstucki mentioned this issue Feb 17, 2023
Closed
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 21, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
ae801c0 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; `x`] =>
case '[type x; Map[`x`, `x`]] =>
case '[type x <: List[Any]; `x`] =>
case '[type f[X]; `f`] =>
case '[type f <: AnyKind; `f`] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Apr 28, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
bcb2c04 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; `x`] =>
case '[type x; Map[`x`, `x`]] =>
case '[type x <: List[Any]; `x`] =>
case '[type f[X]; `f`] =>
case '[type f <: AnyKind; `f`] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Apr 28, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
40c2922 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; `x`] =>
case '[type x; Map[`x`, `x`]] =>
case '[type x <: List[Any]; `x`] =>
case '[type f[X]; `f`] =>
case '[type f <: AnyKind; `f`] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Apr 28, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
2d3136f 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Apr 28, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
713c246 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 2, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
e5fd109 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
@nicolasstucki nicolasstucki linked a pull request May 2, 2023 that will close this issue
SIP-53 - Quote pattern explicit type variable syntax #17362
Merged
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 2, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
14cf508 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 2, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
a726494 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 3, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
6932f9e 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 3, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
7cb8d05 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 4, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
9d81edb 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 8, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
b58464b 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 12, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
646f2f9 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 23, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
379a06b 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 31, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
bf472e3 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 31, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
6cb6ae3 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jun 7, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
f767c6e 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jun 16, 2023
@nicolasstucki
Support type variable definitions in quoted patterns
5938d65 
Support explicit type variable definition in quoted patterns.
This allows users to set explicit bounds or use the binding twice.
Previously this was only possible on quoted expression patterns case '{ ... }.

```scala
case '[type x; x] =>
case '[type x; Map[x, x]] =>
case '[type x <: List[Any]; x] =>
case '[type f[X]; f] =>
case '[type f <: AnyKind; f] =>
```

Fixes scala#10864
Fixes scala#11738
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metaprogramming:quotes Issues related to quotes and splices itype:language enhancement
Projects
None yet
Milestone
3.4.0
5 participants
@OlivierBlanvillain @nicolasstucki @Katrix @Kordyjan @IndiscriminateCoding