Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #413

Closed
10 tasks done
SethTisue opened this issue Jan 21, 2021 · 13 comments
Closed
10 tasks done

Release 2.4.0 #413

SethTisue opened this issue Jan 21, 2021 · 13 comments
Assignees

Comments

@SethTisue
Copy link
Member

SethTisue commented Jan 21, 2021

Motivations:

Steps:

@SethTisue SethTisue self-assigned this Jan 21, 2021
@lolgab
Copy link
Contributor

lolgab commented Jan 22, 2021

Is there any ETA for this release?
You should probably merge this one first.

@SethTisue
Copy link
Member Author

If I don't get to it today, then early next week.

@lolgab
Copy link
Contributor

lolgab commented Jan 22, 2021

@SethTisue Cool, thank you! 🙏

@SethTisue
Copy link
Member Author

the 3.0.0-M2 artifacts haven't shown up on Maven Central, but the others have. hopefully it's just that some extra patience is needed...

@sideeffffect
Copy link

sideeffffect commented Jan 27, 2021

Is it possible that just because of some change from 2.3.2 to 2.4.0 I'm suddenly getting errors like this

[error] /home/runner/work/izumi-reflect/izumi-reflect/izumi-reflect/izumi-reflect/src/main/scala/izumi/reflect/internal/fundamentals/collections/IzMappings.scala:26:4: expected literal string as @nowarn annotation argument
[error]   @nowarn("msg=deprecated")
[error]    ^

?
zio/izumi-reflect#125

@ekrich
Copy link
Contributor

ekrich commented Jan 27, 2021

Working for JVM and JS 2.11 - 3.0.0-M3 (no M2) and Native 2.11 - 2.13 for ekrich/sconfig. Thanks!

@SethTisue
Copy link
Member Author

SethTisue commented Jan 27, 2021

@sideeffffect presumably related to #417 — please open a ticket with details: what Scala version(s) are affected, whether it happens on JVM or JS or Native or all three, whether use of silencer might be a factor, etc etc, and we'll figure it out

@jodersky
Copy link

Would it be possible to also publish 2.4.0 for scala js 0.6?

@SethTisue
Copy link
Member Author

@jodersky hmm, well I'd honestly really rather not. at least not unless it's creating some kind of serious roadblock for actual 0.6 users. is there a real need for 0.6 users not to just leave the dependency frozen at whatever version they're already on? most of the repos I'm involved with dropped 0.6 support a while ago

@jodersky
Copy link

jodersky commented Jan 27, 2021

It's not a huge problem, but for projects that cross-build, it does make the build matrix much more complex. The reason I asked was for unblocking com-lihaoyi/upickle#330, but in the end we were able to drop the dependency on scala-collection-compat altogether, so it's not an issue there anymore.

@SethTisue
Copy link
Member Author

the 3.0.0-M2 artifacts haven't shown up on Maven Central, but the others have. hopefully it's just that some extra patience is needed...

nope. Sonatype just.... disappeared them, like mobsters disappearing a murder witness

or maybe I'm jumping to conclusions and there is somehow something wrong in the build? https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_sjs1_3.0.0-M2/2.4.0/ is also missing

over at https://travis-ci.com/github/scala/scala-collection-compat/builds/214738364 , I hit restart on both M2 jobs, which should make them publish again, to new staging repos

new logs:

aha! the jobs say M2 on them, but the artifacts say M3. I apologize to the Sonatype-American community.

let's take a closer look at https://travis-ci.com/github/scala/scala-collection-compat/jobs/476713037

it does have TRAVIS_SCALA_VERSION -> 3.0.0-M2

but then [info] compiling 19 Scala sources to /home/travis/build/scala/scala-collection-compat/.cross/compat30/jvm/target/scala-3.0.0-M3/test-classes ...

so I guess this has something to do with the weird way this repo is set up (#395 is where we complain about that)

and aha, build.sbt has lazy val scala30 = "3.0.0-M3" and it does val compatProject = "compat" + travisScalaVersion.get.binary + platformSuffix but otherwise ignores travisScalaVersion

okay, I'll PR a fix

@SethTisue
Copy link
Member Author

#420 🌿

@SethTisue
Copy link
Member Author

SethTisue commented Jan 30, 2021

Because publishing is weird in this repo, I don't trust myself to attempt to back-publish, and anyway I want to be sure that full publishing is still working. So I'm going to roll 2.4.1: #422

@SethTisue SethTisue mentioned this issue Jan 30, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants