Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pushing scala updates for non LTS versions #3302

Closed
etspaceman opened this issue Feb 28, 2024 · 6 comments · Fixed by #3328
Closed

Avoid pushing scala updates for non LTS versions #3302

etspaceman opened this issue Feb 28, 2024 · 6 comments · Fixed by #3328

Comments

@etspaceman
Copy link

It would be very helpful if updates for the scala language were limited to the LTS versions unless otherwise configured. The Steward pushed out versions for 3.4 recently and this version is not intended for libraries.

@bpholt
Copy link
Contributor

bpholt commented Feb 28, 2024

Related #2467

@SethTisue
Copy link
Contributor

(now that I'm back on my computer I see that) It's possible this was already fixed, as at modules/core/src/main/resources/default.scala-steward.conf I see

  // Ignore the next Scala 3 version until it is announced.
  { groupId = "org.scala-lang", artifactId = "scala3-compiler",     version = { exact = "3.4.0" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library",      version = { exact = "3.4.0" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.4.0" } },

@Kordyjan but of course this is specific to 3.4.0; is there some update to the Scala 3 release steps that is still needed to prevent this from reoccurring...?

@Kordyjan
Copy link
Contributor

For now, 3.4 releases are ignored. It will remain that way for some time. Later, we will propose a change to the Scala steward to only bump the version to the Scala Next version if the project is already on Scala Next.

@valencik
Copy link

@Kordyjan

For now, 3.4 releases are ignored.

It looks like updates are still going out: typelevel/typelevel.g8#135

@mpilquist
Copy link
Contributor

Another example: Comcast/ip4s#575

@mzuehlke
Copy link
Member

#3323 should fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants