Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the types into their respective function definition files #8

Open
sbp opened this issue Aug 18, 2017 · 1 comment
Open

Move the types into their respective function definition files #8

sbp opened this issue Aug 18, 2017 · 1 comment

Comments

@sbp
Copy link
Owner

sbp commented Aug 18, 2017

Coq defines its types in Numbers.BinNums which seems a little strange to me. It may be because they modularise [NPZ]Arith over so many files and they found that it's better to import the types into each file rather than do chained exporting.

On the other hand, in idris-bi we're keeping everything in the files Bip.idr, Bin.idr, and Biz.idr. It might be a good idea to move Bip into Bip.idr and so on. That way we would eliminate the Bi.idr file entirely. Who's really going to import Data.Bi without importing one of the other files?

@clayrat
Copy link
Collaborator

clayrat commented Aug 21, 2017

Yeah, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants